Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(makefile): add format target #468

Merged
merged 1 commit into from
Sep 5, 2023
Merged

ci(makefile): add format target #468

merged 1 commit into from
Sep 5, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Sep 4, 2023

  • add format target to Makefile.toml that actually fixes the formatting
  • rename fmt target to lint-format
  • rename style-check target to lint-style
  • rename typos target to lint-typos
  • rename check-docs target to lint-docs
  • add section to CONTRIBUTING.md about formatting

@joshka
ci(makefile): add format target
58ee5a9 
- add format target to Makefile.toml that actually fixes the formatting
- rename fmt target to lint-format
- rename style-check target to lint-style
- rename typos target to lint-typos
- rename check-docs target to lint-docs
- add section to CONTRIBUTING.md about formatting
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #468 (58ee5a9) into main (343c6cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          40       40           
  Lines       11156    11156           
=======================================
  Hits        10041    10041           
  Misses       1115     1115

@joshka joshka merged commit b996102 into main Sep 5, 2023
@joshka joshka deleted the ci-add-format-target branch September 5, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindoodoo mindoodoo mindoodoo approved these changes

@kdheepak kdheepak kdheepak approved these changes

@orhun orhun Awaiting requested review from orhun

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@sophacles sophacles Awaiting requested review from sophacles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshka @kdheepak @mindoodoo